So, it's December. I got a lot done in November, and a lot of the priorities that I outlined there continue to be my priorities for this month. For those that don't normally read these, I typically keep track of what I change here so that other admins can see whether or not something spontaneously broke, or whether I touched it and it broke. There's a lot to do, so let's get started:
Dec 2
- Removed htmlvars stuff from e2nodelock
- Removed $HTMLVARS{search_group}, $HTMLVARS{permission_denied} from HTML.pm, set_htmlvars, and system settings.
- Removed the unused key 'roomTextboxLevel' from system settings
- Winding down the HTMLVARS{roomCreateLevel} from: createroom, room maintenance create, rootbeer277's other sandbox, create room. Took it out of system settings
- Replacing the userSettings_node: epicenterzen, epicenter, and a custom nodelet. Removed it from system settings
- Made Page of Cool unnukable. Removed it from system settings
- Made Writeup Deletion Request unnukable, and marked it as a maintenance node. Removed it from system settings
- Working on styleSheetFixLevel in system settings: fixstylesheet, settings, stylesheet display page, stylesheet serve page
Dec 3
- Removed $HTMLVARS{login_node} from e2createnewnode.
- Removed the last two HTMLVARS from sayings_nwing
- Continued HTMLVARS removal: newwriteups2, showchatter, ordernode, repair_e2node, repaire2node, flushcbox, borg, hidewriteup, Usergroup Writeups
- Nuked the unused: newwriteups3
- Increased personal nodelet size to 70 for admins/editors. Removed HTMLVARS stuff from it.
- Killed some zombie code from Everything Developer, jukka container, showFooter, changeusergroup
- Nuked ednsection_everydevel. It was disabled and there's no more everydevel.
- Nuked Everything Developer Data, it wasn't being used. Same with ednsection_documents.
- Stripped 'edn_hidedocuments' from 167 accounts.
- Simplified permissions in: E2 Collaboration Nodes
Dec 4
- Removed HTMLVARS{klaproth} calls from showmessages,testshowmessages
- Reworked Page of Cool,Editor Endorsements to not use HTMLVARS
- Removed the group_gods call in: Message Inbox 2, Message Inbox Grouper, Big Writeup Lists, Recent Users, mark all discussions as read
- Simplified the permissions check in Archived E2 FAQ: Polls, The Oracle, nodenote
- Nuked: Archived E2 FAQ: Using PayPal to donate funds to Everything2
- Nuked: Witness Protection Program, as it admitted it wasn't ready for primetime
- Nuked: user auditor, as it was something I didn't finish say, 10 years ago?
- Fixed an editor check in rootbeer277's other sandbox
- Changed gods check in pseudoExec test
- Nuked: N-Wing tries a Message Inbox rewrite, as it wasn't working and hadn't been updated in like 5 years.
- Nuked: Everything Poll Editor, as it said it was retired.
- Killed zombie code in Everything Publication Directory
- Nuked the retired: Everything Discussion Directory
- Nuked the retired uninsure
- Changed the check inside of: unhidewriteup
- Stripped the 'edn_hideeverydevel' var from 217 accounts.
- Cleaned up the permissions check in orderlock
- Cleanup more in E2 Ticket Center.
- Change the developer check in Cool Archive
- Nuked nodeletwidget, as it was an unfinished work in progress.
- Nuked adbox as it isn't being used anymore
- Took out the impotent adfu preference in Advanced Settings. Stripped the 'noadinheader' $VARS entry from ~900 accounts
- Nuked synctitles, as it wasn't used anywhere.
- Simplified the editor check in: repair_e2node_noreorder, nodetestpass, message
- Cleaned out all of the HTMLVARS entries in: Other Users - Zen
- Same as above: settingsDocs
- Implemented a new global with which to fold NODELET and the %HTMLVARS carry stuff into: $PAGELOAD. It gets cleared every load, so it's safe to use.
- Made some bridge code in page header, and advanced settings, Settings, classic user edit page, Admin Settings, Nodelet Settings
- Removed bridge code in page header
- Removed HTMLVARS shenanigans from Short URL Lookup
- Removed HTMLVARS from the newly-rewritten node_forward display page
Dec 5
- Removed more HTMLVARS stuff rootbeer277's other sandbox, chanops check
- Created some bridge code to move over the 'pagenodelets' stuff out of it. nodelet meta-container node listnodelets page
- Removed the HTMLVARS{pagenodelets} stuff from: nodelet meta-container, Guest Front Page, Chatterlighter, Everything2 - Oolong's Front Page,
- Removed bridge code: nodelet meta-container node listnodelets page
- Working on 'noparsecodelinks'. Created bridge code in parsecode
- Ripping out 'noparsecodelinks' for the $PAGELOAD version: ajax update,monthly patch lister, guest front page
- Undid bridge in parsecode
- Removed mercurial link from ednsection_patches
- Removed HTMLVARS{isDevServer} from Patch Importer. Also disabled it.
- Removed HTMLVARS{isDevServer} for $APP->inDevEnvironment(): applypatch, angelToDraft, static javascript.
- Removed $HTMLVARS{ignoreMissingJsLibraries} also from static javascript, as it isn't used anywhere else.
- Nuked polledit, which is not used anywhere.
- Nuked Archived E2 FAQ: Polls
- Nuked the only remaining broken e2poll type: Chinese Zodiac
- Removed the convertoldpoll bits from showpoll
- Nuked convertOldPoll, as it isn't needed anymore.
- Removed two instances of HTMLVARS{group_gods} from Other Users,
- Removed pseudoexec from chatterbox, ajax chatterbox chatterbox xml ticker
- Nuked: pseudoExec test, pseudoExec
- Ditching writeuplowrepthreshold for an E::CONF entry: canseewriteup, zenwriteups,Advanced Settings. Removed the entry from system settings
- Various HTMLVARS fixes in Chatterbox
- Made consistent the logic in AJAX Chatterbox to include Chanops
- Changed zen e2node display page to move $HTMLVARS{admintools} to use $PAGELOAD->{admintools} instead.
Dec 7
- Removed more HTMLVARS junk from jscript display page, document display page, debatecomment atom page, collaboration useredit page, collaboration display page, category edit page, zendisplayuserinfo, showchatter, newnodes, under construction
- Nuked the scratch pad node_forward.
- Nuked zenTableWriteups as it didn't appear to be used anywhere.
- Cleaned out zombie code from joker's chat
- Nuked the unused spiffyhome
- Wound down a 'mildly evil hack' in weblog. Replaced with a slightly less evil hack
- Took more HTMLVARS stuff out of: usergroupmultipleadd, votefoot
- Removed the edev check from votehead, since I can't think of any special powers edev has like that
- Pushed the weblogform caching options into $PAGELOAD, which is better than HTMLVARS for now
- Took the HTMLVARS carry hack out of writeuphints
Dec 8
- More cleanups for HTMLVARS: testshowmessages,listcode,writeuphints,softlock,settype, softlink,showusergroups,screennotelet,showmessages, repair e2node,orderlock, legacyweblog, movenodelet, formxml_user, formxml_superdoc, e2nodetools,displayuserinfo
- Nuked the otherwise not needed showchatterrand
- Cleaned up zombie code in selectwriteuptypes
- Nuked the unimplemented selectwriteuptypesresults
- Nuked the super old nodehelpadmin
- Removed the helplink and updated the corporate info in new classic container
- Nuked helplink, as it wasn't truly used.
- Nuked getHTMLVAR, as it wasn't used and that whole concept is going away.
- Nuked logwriteups as it wasn't used.
- Nuked e2softlock as it wasn't used.
- Winding down the Dreams nodelet; Stripping it from 82 accounts. Removed invalid nodelets from another 160+
- Nuked the Dreams nodelet.
- Nuked dreamwriteups and dreamwuamount, as they were only used in the Dreams nodelet.
- Stripped the 'num_dreamwus' VARS from one account.
- Refactored logwarning to not use HTMLVARS
Dec 11
- Took HTMLVARS out of ednsection_globals
- Moved guest_link to Everything::CONF inside of Everything::HTML
- Nuked set_htmlvars. Node_id 49.
- Nuked system settings. Even though I was like, 100% sure that it was okay, i still cringed a bit
- %HTMLVARS is dead.
- Commented out nagger out of the development environment.
Dec 12
- Edited Everything2 Ajax so that the development environment (which has a port associated with the url) will work fine. This is important so I can develop new cool features without breaking anything.
Dec 13
- Cleaned up root's view of the world by nuking some weird prefs that it had; this should help the development environment
Dec 20
- Hunting down various issues related to mod_perl caching if we don't initialize variables to be blank or if we conditionally initialize them. This is super important for performance. I am going to turn this on the week after Christmas when I can sit down and really look at the site to make sure it's okay. changeroom
- Clear out mod_perl unsafeties: page actions, page header
- Adding a temporary parameter to htmlcode (the dbtable), called 'modperlsafe' which will dictate whether or not we store a compiled version inside of the node, similar to how getCompiledCode works now. I'll need to audit all of the htmlcodes to make sure that they don't have cache-poisoning problems with conditional initialization, though we might be there now without knowing it.
- Marked changeroom as mod_perl safe.
Dec 27
- Going through and auditing every HTMLCODE for modperl safety. This is a huge performance boost: paramsetbox, metadescriptiontag, guestuserbanner, addnote, checkvar, closeform, displayInherited,displayNODE, groupeditor, listFields, listcode,listgroup,nodelet meta-container, onepix, openform, parselinks, parsetime, password_field, searchform, serverstats, mysqlproctest, setvar, shownote, textfield,titlebar, userbody,varMenu, windowview,showwriteup, displaywriteup, displaytable, displayvars,editvars
- Nuked: encodehtml, checkvar, settingList, groupList, groupmenu, settingMenu, testtypemenu, limitededitvars
- Disabled the guestuserbanner for a while to see if it helps with our pagerank.
Dec 31
- More mod_perl safety: e2 logos, clearimage, softlink, listwriteups, coolit,node_menu,typeMenu, randomnode, e2createnewnode, daylog, showbookmarks, episection_admins, borgcheck, bookmarkit, newnodes, shownewexp,setupuservars, displaynltext, thinoutlineheader, thinoutlinefooter, writeuphints, varcheckbox, createdby
- Nuked askify. Unused.
- Nuked coolsafety. Blank.
- Nuked image upload page. Wouldn't work, even if I wanted it to.
- Nuked testuploadimage. Also wouldn't work.
- Nuked getBorderSize. Unused.
- Nuked schemahead. Unused.
- Nuked explainsql. Unused.